drgreen/android_frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
android_frameworks_base/core/res/OWNERS

52 lines
1.5 KiB
Plaintext
Raw Normal View History

Improve OWNERS coverage across frameworks/base/. As general background, OWNERS files expedite code reviews by helping code authors quickly find relevant reviewers, and they also ensure that stakeholders are involved in code changes in their areas. Some teams under frameworks/base/ have been using OWNERS files successfully for many years, and we're ready to expand them to cover more areas. Here's the historical coverage statistics for the last two years of changes before these new OWNERS changes land: -- 56% of changes are fully covered by OWNERS -- 17% of changes are partially covered by OWNERS -- 25% of changes have no OWNERS coverage Working closely with team leads, we've now identified clear OWNERS on a per-package basis, and we're using "include" directives whenever possible to to simplify future maintenance. With this extensive effort, we've now improved our coverage as follows: -- 98% of changes are fully covered by OWNERS -- 1% of changes are partially covered by OWNERS -- 1% of changes have no OWNERS coverage This specific change begins defining top-level OWNERS lists, including a general catch-all for string translations. Bug: 174932174 Test: manual Exempt-From-Owner-Approval: refactoring with team leads buy-in Change-Id: Ie7ac3302d40a717fa048115cca2ea4359de64959
2020-12-05 22:30:34 -07:00
adamp@google.com
Additional SysUI leads in OWNERS for resources in frameworks/base/core. Change-Id: I496937c15b253255b258ecb5894778d2eefe2970
2021-01-13 20:43:10 +00:00
asc@google.com
Updating owners in core and in resources Adding cinek as owner of base framework and adding members of Sysui Motion & gfx as owners of resources as we have to touch these often. Bug: N/A Test: add code changes, observe new ownership Change-Id: I2b8c4a0e38b425b85d008a3589569a42f2b59556
2021-05-03 11:14:59 +02:00
cinek@google.com
Improve OWNERS coverage across frameworks/base/. As general background, OWNERS files expedite code reviews by helping code authors quickly find relevant reviewers, and they also ensure that stakeholders are involved in code changes in their areas. Some teams under frameworks/base/ have been using OWNERS files successfully for many years, and we're ready to expand them to cover more areas. Here's the historical coverage statistics for the last two years of changes before these new OWNERS changes land: -- 56% of changes are fully covered by OWNERS -- 17% of changes are partially covered by OWNERS -- 25% of changes have no OWNERS coverage Working closely with team leads, we've now identified clear OWNERS on a per-package basis, and we're using "include" directives whenever possible to to simplify future maintenance. With this extensive effort, we've now improved our coverage as follows: -- 98% of changes are fully covered by OWNERS -- 1% of changes are partially covered by OWNERS -- 1% of changes have no OWNERS coverage This specific change begins defining top-level OWNERS lists, including a general catch-all for string translations. Bug: 174932174 Test: manual Exempt-From-Owner-Approval: refactoring with team leads buy-in Change-Id: Ie7ac3302d40a717fa048115cca2ea4359de64959
2020-12-05 22:30:34 -07:00
dsandler@android.com
dsandler@google.com
Additional SysUI leads in OWNERS for resources in frameworks/base/core. Change-Id: I496937c15b253255b258ecb5894778d2eefe2970
2021-01-13 20:43:10 +00:00
dupin@google.com
Improve OWNERS coverage across frameworks/base/. As general background, OWNERS files expedite code reviews by helping code authors quickly find relevant reviewers, and they also ensure that stakeholders are involved in code changes in their areas. Some teams under frameworks/base/ have been using OWNERS files successfully for many years, and we're ready to expand them to cover more areas. Here's the historical coverage statistics for the last two years of changes before these new OWNERS changes land: -- 56% of changes are fully covered by OWNERS -- 17% of changes are partially covered by OWNERS -- 25% of changes have no OWNERS coverage Working closely with team leads, we've now identified clear OWNERS on a per-package basis, and we're using "include" directives whenever possible to to simplify future maintenance. With this extensive effort, we've now improved our coverage as follows: -- 98% of changes are fully covered by OWNERS -- 1% of changes are partially covered by OWNERS -- 1% of changes have no OWNERS coverage This specific change begins defining top-level OWNERS lists, including a general catch-all for string translations. Bug: 174932174 Test: manual Exempt-From-Owner-Approval: refactoring with team leads buy-in Change-Id: Ie7ac3302d40a717fa048115cca2ea4359de64959
2020-12-05 22:30:34 -07:00
hackbod@android.com
hackbod@google.com
Add team members to core/res/OWNERS Test: Presubmit Change-Id: I42d508836b409d5e1263e330221ea41d77fb9e21
2021-02-02 16:45:25 -08:00
ilyamaty@google.com
jaggies@google.com
Improve OWNERS coverage across frameworks/base/. As general background, OWNERS files expedite code reviews by helping code authors quickly find relevant reviewers, and they also ensure that stakeholders are involved in code changes in their areas. Some teams under frameworks/base/ have been using OWNERS files successfully for many years, and we're ready to expand them to cover more areas. Here's the historical coverage statistics for the last two years of changes before these new OWNERS changes land: -- 56% of changes are fully covered by OWNERS -- 17% of changes are partially covered by OWNERS -- 25% of changes have no OWNERS coverage Working closely with team leads, we've now identified clear OWNERS on a per-package basis, and we're using "include" directives whenever possible to to simplify future maintenance. With this extensive effort, we've now improved our coverage as follows: -- 98% of changes are fully covered by OWNERS -- 1% of changes are partially covered by OWNERS -- 1% of changes have no OWNERS coverage This specific change begins defining top-level OWNERS lists, including a general catch-all for string translations. Bug: 174932174 Test: manual Exempt-From-Owner-Approval: refactoring with team leads buy-in Change-Id: Ie7ac3302d40a717fa048115cca2ea4359de64959
2020-12-05 22:30:34 -07:00
jsharkey@android.com
jsharkey@google.com
Add juliacr@ to core/res/OWNERS Change-Id: I1fb6814dc965158f23a3c6453ce6f7eb61445e53
2020-12-16 15:22:13 +00:00
juliacr@google.com
Add team members to core/res/OWNERS Test: Presubmit Change-Id: I42d508836b409d5e1263e330221ea41d77fb9e21
2021-02-02 16:45:25 -08:00
kchyn@google.com
Improve OWNERS coverage across frameworks/base/. As general background, OWNERS files expedite code reviews by helping code authors quickly find relevant reviewers, and they also ensure that stakeholders are involved in code changes in their areas. Some teams under frameworks/base/ have been using OWNERS files successfully for many years, and we're ready to expand them to cover more areas. Here's the historical coverage statistics for the last two years of changes before these new OWNERS changes land: -- 56% of changes are fully covered by OWNERS -- 17% of changes are partially covered by OWNERS -- 25% of changes have no OWNERS coverage Working closely with team leads, we've now identified clear OWNERS on a per-package basis, and we're using "include" directives whenever possible to to simplify future maintenance. With this extensive effort, we've now improved our coverage as follows: -- 98% of changes are fully covered by OWNERS -- 1% of changes are partially covered by OWNERS -- 1% of changes have no OWNERS coverage This specific change begins defining top-level OWNERS lists, including a general catch-all for string translations. Bug: 174932174 Test: manual Exempt-From-Owner-Approval: refactoring with team leads buy-in Change-Id: Ie7ac3302d40a717fa048115cca2ea4359de64959
2020-12-05 22:30:34 -07:00
michaelwr@google.com
nandana@google.com
narayan@google.com
ogunwale@google.com
patb@google.com
Updating owners in core and in resources Adding cinek as owner of base framework and adding members of Sysui Motion & gfx as owners of resources as we have to touch these often. Bug: N/A Test: add code changes, observe new ownership Change-Id: I2b8c4a0e38b425b85d008a3589569a42f2b59556
2021-05-03 11:14:59 +02:00
shanh@google.com
tsuji@google.com
Improve OWNERS coverage across frameworks/base/. As general background, OWNERS files expedite code reviews by helping code authors quickly find relevant reviewers, and they also ensure that stakeholders are involved in code changes in their areas. Some teams under frameworks/base/ have been using OWNERS files successfully for many years, and we're ready to expand them to cover more areas. Here's the historical coverage statistics for the last two years of changes before these new OWNERS changes land: -- 56% of changes are fully covered by OWNERS -- 17% of changes are partially covered by OWNERS -- 25% of changes have no OWNERS coverage Working closely with team leads, we've now identified clear OWNERS on a per-package basis, and we're using "include" directives whenever possible to to simplify future maintenance. With this extensive effort, we've now improved our coverage as follows: -- 98% of changes are fully covered by OWNERS -- 1% of changes are partially covered by OWNERS -- 1% of changes have no OWNERS coverage This specific change begins defining top-level OWNERS lists, including a general catch-all for string translations. Bug: 174932174 Test: manual Exempt-From-Owner-Approval: refactoring with team leads buy-in Change-Id: Ie7ac3302d40a717fa048115cca2ea4359de64959
2020-12-05 22:30:34 -07:00
yamasani@google.com
OWNERS file entry for config_user_types.xml Change-Id: Ib1e9721a35be96a84f3b83421ba96f4d7c903c13 Test: N/A
2021-07-22 17:18:59 +00:00
Include WindowManager owners in core/res/OWNERS Resources used in WindowManager Core are added to frameworks/base/core/res/ so we often run into problem where WindowManager owners can't fully approve CLs that have trivial changes in resource files. Bug: 262439469 Change-Id: Ifdf283aed9b7803ca403bec2e5c21c3dfcc4e824 Test: manual
2022-12-13 23:25:53 +00:00
# WindowManager team
# TODO(262451702): Move WindowManager configs out of config.xml in a separate file
Correct path to files in core/res/OWNERS Bug: 262439469 Change-Id: Ida7cf2aadd190fcd582943801167eed4c535cadb Test: manual
2023-01-13 18:54:39 +00:00
per-file res/values/config.xml = file:/services/core/java/com/android/server/wm/OWNERS
per-file res/values/symbols.xml = file:/services/core/java/com/android/server/wm/OWNERS
Include WindowManager owners in core/res/OWNERS Resources used in WindowManager Core are added to frameworks/base/core/res/ so we often run into problem where WindowManager owners can't fully approve CLs that have trivial changes in resource files. Bug: 262439469 Change-Id: Ifdf283aed9b7803ca403bec2e5c21c3dfcc4e824 Test: manual
2022-12-13 23:25:53 +00:00
Fix some resources OWNERS files Bug: 222537368 Change-Id: I40dc3fec68157f36a2a064324412eda85f9d8789
2022-03-04 00:11:50 +00:00
# Resources finalization
per-file res/xml/public-staging.xml = file:/tools/aapt2/OWNERS
per-file res/xml/public-final.xml = file:/tools/aapt2/OWNERS
OWNERS file entry for config_user_types.xml Change-Id: Ib1e9721a35be96a84f3b83421ba96f4d7c903c13 Test: N/A
2021-07-22 17:18:59 +00:00
# Multiuser
per-file res/xml/config_user_types.xml = file:/MULTIUSER_OWNERS
Specify per-file owner for dimens_car.xml Bug: 202314754 Test: No need Change-Id: If0042d64c55484ae361fc08e785e74c026247553
2021-10-21 13:54:08 -07:00
# Car
Add owners to wear specific resources. Bug: 208246426 Test: N/A Ignore-AOSP-First: frameworks/opt/wear project doesn't exist in AOSP Change-Id: If9f466ca7c24b5b847eb9547af142a228a2ad6da
2021-12-02 14:11:51 -08:00
per-file res/values/dimens_car.xml = file:/platform/packages/services/Car:/OWNERS
Set OWNERS for Device Idle configuration file. Bug: 233834601 Change-Id: Idc7f833cdd2addf47ae6f9dee151a105c9b49d58 Test: N/A
2022-09-12 22:24:19 +00:00
# Device Idle
per-file res/values/config_device_idle.xml = file:/apex/jobscheduler/OWNERS
Add owners to wear specific resources. Bug: 208246426 Test: N/A Ignore-AOSP-First: frameworks/opt/wear project doesn't exist in AOSP Change-Id: If9f466ca7c24b5b847eb9547af142a228a2ad6da
2021-12-02 14:11:51 -08:00
# Wear
Duplicate wear owners to frameworks/base/WEAR_OWNERS We can't depend on frameworks/opt/wear from frameworks/base due to wear projects not available in AOSP. So it's necessary to duplicate the owners in a new file in frameworks/base. Bug: 246359459 Fix: 246359459 Test: N/A Change-Id: I5f5385a696721b2254233ce314d1d7e3fae25d39
2022-09-12 14:23:32 -07:00
per-file res/*-watch/* = file:/WEAR_OWNERS
Add BatteryStats owners to PowerProfile ownership Bug: 194419357 Test: n/a Change-Id: I088fb2513c906a4aee46791049a6bdb80f525a0f Ignore-AOSP-First: fix merge conflict with master
2022-01-20 15:03:36 -08:00
# PowerProfile
per-file res/xml/power_profile.xml = file:/BATTERY_STATS_OWNERS
per-file res/xml/power_profile_test.xml = file:/BATTERY_STATS_OWNERS
Moved telephony related resource to a separate file Test: Build Bug: None Ignore-AOSP-First: Merge conflict Change-Id: Iebbee458035538f47ebd82fb7b9ba5fcf74d33db
2022-04-03 01:09:30 -07:00
# Telephony
per-file res/values/config_telephony.xml = file:/platform/frameworks/opt/telephony:/OWNERS
Update OWNERs file for telephony xml files Bug: 213183041 Test: make Ignore-AOSP-First: Merge conflict Change-Id: If64d1f34038472dcafd9a94f24879ae9d3056bb1 (cherry picked from commit 262fac8141b3072036a55badd9abdd15582e3ecc) Merged-In: If64d1f34038472dcafd9a94f24879ae9d3056bb1
2022-05-02 11:50:47 -07:00
per-file res/xml/sms_short_codes.xml = file:/platform/frameworks/opt/telephony:/OWNERS
Reference in New Issue Copy Permalink