2015-08-14 14:26:04 -07:00
|
|
|
/*
|
|
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "compile/IdAssigner.h"
|
2016-10-21 17:56:45 -07:00
|
|
|
|
2016-06-01 15:31:50 -07:00
|
|
|
#include "test/Test.h"
|
2015-08-14 14:26:04 -07:00
|
|
|
|
|
|
|
namespace aapt {
|
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
::testing::AssertionResult VerifyIds(ResourceTable* table);
|
2015-08-14 14:26:04 -07:00
|
|
|
|
|
|
|
TEST(IdAssignerTest, AssignIds) {
|
2016-10-19 12:18:14 -07:00
|
|
|
std::unique_ptr<ResourceTable> table = test::ResourceTableBuilder()
|
2016-10-21 17:56:45 -07:00
|
|
|
.AddSimple("android:attr/foo")
|
|
|
|
.AddSimple("android:attr/bar")
|
|
|
|
.AddSimple("android:id/foo")
|
|
|
|
.SetPackageId("android", 0x01)
|
|
|
|
.Build();
|
2016-10-19 12:18:14 -07:00
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build();
|
2016-10-19 12:18:14 -07:00
|
|
|
IdAssigner assigner;
|
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
ASSERT_TRUE(assigner.Consume(context.get(), table.get()));
|
|
|
|
ASSERT_TRUE(VerifyIds(table.get()));
|
2015-08-14 14:26:04 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
TEST(IdAssignerTest, AssignIdsWithReservedIds) {
|
2016-10-19 12:18:14 -07:00
|
|
|
std::unique_ptr<ResourceTable> table =
|
|
|
|
test::ResourceTableBuilder()
|
2016-10-21 17:56:45 -07:00
|
|
|
.AddSimple("android:id/foo", ResourceId(0x01010000))
|
|
|
|
.AddSimple("android:dimen/two")
|
|
|
|
.AddSimple("android:integer/three")
|
|
|
|
.AddSimple("android:string/five")
|
|
|
|
.AddSimple("android:attr/fun", ResourceId(0x01040000))
|
|
|
|
.AddSimple("android:attr/foo", ResourceId(0x01040006))
|
|
|
|
.AddSimple("android:attr/bar")
|
|
|
|
.AddSimple("android:attr/baz")
|
|
|
|
.AddSimple("app:id/biz")
|
|
|
|
.SetPackageId("android", 0x01)
|
|
|
|
.SetPackageId("app", 0x7f)
|
|
|
|
.Build();
|
|
|
|
|
|
|
|
std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build();
|
2016-10-19 12:18:14 -07:00
|
|
|
IdAssigner assigner;
|
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
ASSERT_TRUE(assigner.Consume(context.get(), table.get()));
|
|
|
|
ASSERT_TRUE(VerifyIds(table.get()));
|
2016-10-19 12:18:14 -07:00
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
Maybe<ResourceTable::SearchResult> maybe_result;
|
2016-10-19 12:18:14 -07:00
|
|
|
|
|
|
|
// Expect to fill in the gaps between 0x0101XXXX and 0x0104XXXX.
|
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
maybe_result = table->FindResource(test::ParseNameOrDie("android:dimen/two"));
|
|
|
|
AAPT_ASSERT_TRUE(maybe_result);
|
|
|
|
EXPECT_EQ(make_value<uint8_t>(2), maybe_result.value().type->id);
|
2016-10-19 12:18:14 -07:00
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
maybe_result =
|
|
|
|
table->FindResource(test::ParseNameOrDie("android:integer/three"));
|
|
|
|
AAPT_ASSERT_TRUE(maybe_result);
|
|
|
|
EXPECT_EQ(make_value<uint8_t>(3), maybe_result.value().type->id);
|
2016-10-19 12:18:14 -07:00
|
|
|
|
|
|
|
// Expect to bypass the reserved 0x0104XXXX IDs and use the next 0x0105XXXX
|
|
|
|
// IDs.
|
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
maybe_result =
|
|
|
|
table->FindResource(test::ParseNameOrDie("android:string/five"));
|
|
|
|
AAPT_ASSERT_TRUE(maybe_result);
|
|
|
|
EXPECT_EQ(make_value<uint8_t>(5), maybe_result.value().type->id);
|
2016-10-19 12:18:14 -07:00
|
|
|
|
|
|
|
// Expect to fill in the gaps between 0x01040000 and 0x01040006.
|
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
maybe_result = table->FindResource(test::ParseNameOrDie("android:attr/bar"));
|
|
|
|
AAPT_ASSERT_TRUE(maybe_result);
|
|
|
|
EXPECT_EQ(make_value<uint16_t>(1), maybe_result.value().entry->id);
|
2016-10-19 12:18:14 -07:00
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
maybe_result = table->FindResource(test::ParseNameOrDie("android:attr/baz"));
|
|
|
|
AAPT_ASSERT_TRUE(maybe_result);
|
|
|
|
EXPECT_EQ(make_value<uint16_t>(2), maybe_result.value().entry->id);
|
2015-08-14 14:26:04 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
TEST(IdAssignerTest, FailWhenNonUniqueIdsAssigned) {
|
2016-10-19 12:18:14 -07:00
|
|
|
std::unique_ptr<ResourceTable> table =
|
|
|
|
test::ResourceTableBuilder()
|
2016-10-21 17:56:45 -07:00
|
|
|
.AddSimple("android:attr/foo", ResourceId(0x01040006))
|
|
|
|
.AddSimple("android:attr/bar", ResourceId(0x01040006))
|
|
|
|
.SetPackageId("android", 0x01)
|
|
|
|
.SetPackageId("app", 0x7f)
|
|
|
|
.Build();
|
2016-10-19 12:18:14 -07:00
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build();
|
2016-10-19 12:18:14 -07:00
|
|
|
IdAssigner assigner;
|
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
ASSERT_FALSE(assigner.Consume(context.get(), table.get()));
|
2015-08-14 14:26:04 -07:00
|
|
|
}
|
|
|
|
|
2016-06-01 15:31:50 -07:00
|
|
|
TEST(IdAssignerTest, AssignIdsWithIdMap) {
|
2016-10-19 12:18:14 -07:00
|
|
|
std::unique_ptr<ResourceTable> table = test::ResourceTableBuilder()
|
2016-10-21 17:56:45 -07:00
|
|
|
.AddSimple("android:attr/foo")
|
|
|
|
.AddSimple("android:attr/bar")
|
|
|
|
.SetPackageId("android", 0x01)
|
|
|
|
.Build();
|
|
|
|
|
|
|
|
std::unique_ptr<IAaptContext> context = test::ContextBuilder().Build();
|
|
|
|
std::unordered_map<ResourceName, ResourceId> id_map = {
|
|
|
|
{test::ParseNameOrDie("android:attr/foo"), ResourceId(0x01010002)}};
|
|
|
|
IdAssigner assigner(&id_map);
|
|
|
|
ASSERT_TRUE(assigner.Consume(context.get(), table.get()));
|
|
|
|
ASSERT_TRUE(VerifyIds(table.get()));
|
2016-10-19 12:18:14 -07:00
|
|
|
Maybe<ResourceTable::SearchResult> result =
|
2016-10-21 17:56:45 -07:00
|
|
|
table->FindResource(test::ParseNameOrDie("android:attr/foo"));
|
2016-10-19 12:18:14 -07:00
|
|
|
AAPT_ASSERT_TRUE(result);
|
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
const ResourceTable::SearchResult& search_result = result.value();
|
|
|
|
EXPECT_EQ(make_value<uint8_t>(0x01), search_result.package->id);
|
|
|
|
EXPECT_EQ(make_value<uint8_t>(0x01), search_result.type->id);
|
|
|
|
EXPECT_EQ(make_value<uint16_t>(0x0002), search_result.entry->id);
|
2016-06-01 15:31:50 -07:00
|
|
|
}
|
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
::testing::AssertionResult VerifyIds(ResourceTable* table) {
|
|
|
|
std::set<uint8_t> package_ids;
|
2016-10-19 12:18:14 -07:00
|
|
|
for (auto& package : table->packages) {
|
|
|
|
if (!package->id) {
|
|
|
|
return ::testing::AssertionFailure() << "package " << package->name
|
|
|
|
<< " has no ID";
|
|
|
|
}
|
2015-08-14 14:26:04 -07:00
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
if (!package_ids.insert(package->id.value()).second) {
|
2016-10-19 12:18:14 -07:00
|
|
|
return ::testing::AssertionFailure()
|
|
|
|
<< "package " << package->name << " has non-unique ID " << std::hex
|
|
|
|
<< (int)package->id.value() << std::dec;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for (auto& package : table->packages) {
|
2016-10-21 17:56:45 -07:00
|
|
|
std::set<uint8_t> type_ids;
|
2016-10-19 12:18:14 -07:00
|
|
|
for (auto& type : package->types) {
|
|
|
|
if (!type->id) {
|
|
|
|
return ::testing::AssertionFailure() << "type " << type->type
|
|
|
|
<< " of package " << package->name
|
|
|
|
<< " has no ID";
|
|
|
|
}
|
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
if (!type_ids.insert(type->id.value()).second) {
|
2016-10-19 12:18:14 -07:00
|
|
|
return ::testing::AssertionFailure()
|
|
|
|
<< "type " << type->type << " of package " << package->name
|
|
|
|
<< " has non-unique ID " << std::hex << (int)type->id.value()
|
|
|
|
<< std::dec;
|
|
|
|
}
|
2015-08-14 14:26:04 -07:00
|
|
|
}
|
|
|
|
|
2016-10-19 12:18:14 -07:00
|
|
|
for (auto& type : package->types) {
|
2016-10-21 17:56:45 -07:00
|
|
|
std::set<uint16_t> entry_ids;
|
2016-10-19 12:18:14 -07:00
|
|
|
for (auto& entry : type->entries) {
|
|
|
|
if (!entry->id) {
|
|
|
|
return ::testing::AssertionFailure()
|
|
|
|
<< "entry " << entry->name << " of type " << type->type
|
|
|
|
<< " of package " << package->name << " has no ID";
|
2015-08-14 14:26:04 -07:00
|
|
|
}
|
|
|
|
|
2016-10-21 17:56:45 -07:00
|
|
|
if (!entry_ids.insert(entry->id.value()).second) {
|
2016-10-19 12:18:14 -07:00
|
|
|
return ::testing::AssertionFailure()
|
|
|
|
<< "entry " << entry->name << " of type " << type->type
|
|
|
|
<< " of package " << package->name << " has non-unique ID "
|
|
|
|
<< std::hex << (int)entry->id.value() << std::dec;
|
2015-08-14 14:26:04 -07:00
|
|
|
}
|
2016-10-19 12:18:14 -07:00
|
|
|
}
|
2015-08-14 14:26:04 -07:00
|
|
|
}
|
2016-10-19 12:18:14 -07:00
|
|
|
}
|
|
|
|
return ::testing::AssertionSuccess() << "all IDs are unique and assigned";
|
2015-08-14 14:26:04 -07:00
|
|
|
}
|
|
|
|
|
2016-10-19 12:18:14 -07:00
|
|
|
} // namespace aapt
|