drgreen/android_frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
android_frameworks_base/PREUPLOAD.cfg

27 lines
1.1 KiB
INI
Raw Normal View History

Enable clang-format for input code Currently, there is no format enforcement for hid command. Add clang-format hook for all input-related code in frameworks/base. Bug: None Test: repo upload Change-Id: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
2019-12-09 16:08:46 -08:00
[Builtin Hooks]
clang_format = true
[Builtin Hooks Options]
# Only turn on clang-format check for the following subfolders.
clang_format = --commit ${PREUPLOAD_COMMIT} --style file --extensions c,h,cc,cpp
cmds/hid/
cmds/input/
Enable clang-format for core/jni To have consistent code style and avoid format-related comments in code review, enable clang-format in frameworks/base/core/jni. Bug: none Test: repo upload Change-Id: Ie9e5408d85036dfabae3a9c60b238b4a190da5fc
2020-01-03 10:59:17 -08:00
core/jni/
Enable clang-format for input code Currently, there is no format enforcement for hid command. Add clang-format hook for all input-related code in frameworks/base. Bug: None Test: repo upload Change-Id: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
2019-12-09 16:08:46 -08:00
libs/input/
Enable clang-format for f/b/services/core/jni To avoid code review comments about code style, line length, and spacing, enable clang-format for frameworks/base/services/core/jni Bug: none Test: repo upload Change-Id: Ie38ecca2d5face78367d3eab450e497120ce12b1
2020-01-27 11:31:29 -06:00
services/core/jni/
Enable clang-format for input code Currently, there is no format enforcement for hid command. Add clang-format hook for all input-related code in frameworks/base. Bug: None Test: repo upload Change-Id: I08b8c6d1bae7d1954847c207ef8e6d80373b2d05
2019-12-09 16:08:46 -08:00
Enable Checkstyle preupload hook for certain frameworks/base directories. Enables Checkstyle preupload hook for the following directories: - core/java/android/animation/ - core/java/android/text/ - core/java/android/view/ - core/java/android/transition/ - core/java/android/widget/ Test: tested manually uploading a CL that contained many changes to directories outside of the listed ones and checkstyle did not complain about those. Change-Id: I795ba478fad7af124c43ca1e18d51b33d7800976
2016-10-11 14:01:36 -07:00
[Hook Scripts]
Point to the new checkstyle location for frameworks/base PREUPLOAD hook. This change depends on r.android.com/314437 Bug: 33666900 Test: None Change-Id: I301723d516803146943f0866ea35b68cc36af6af
2016-12-15 15:01:36 -08:00
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}
Check USB and Print Framework code. Test: Uploaded Change-Id: Ib103a4fdc1dea0efc3a1a1be8c864541d283343a
2016-10-20 17:09:39 -07:00
Add linter for strings.xml. Strings are tedious to get right, so write a lint script that catches common errors to warn developers before they're uploaded. Test: builds, boots Bug: 76097999 Change-Id: I9826ca796c17cd93a100951d56214653de63a379
2018-03-26 09:38:01 -06:00
strings_lint_hook = ${REPO_ROOT}/frameworks/base/tools/stringslint/stringslint_sha.sh ${PREUPLOAD_COMMIT}
Add presubmit hook for hidden API lists. Check that they're sorted as expected and contain no duplicates. The sort order now uses: $ LC_COLLATE=C sort -f So that non-alphanumeric characters are not ignored, giving a more intuitive sort order. the '-f' means ignore case. Also sort the existing lists accordingly. Test: repo upload Bug: 64382372 Merged-In: I52b884da33a9a46455df6747a215683d9d3c3218 Change-Id: I4cdd3bc5c11be91a9a3f678580af49ac67f3c968
2018-04-23 16:13:14 +01:00
Prevent hiddenapi entries being added for libcore related projects The libcore related projects (see below) have been (mostly) switched over to use UnsupportedAppUsage annotations, This change will prevent entries for those projects being added to a config/hiddenapi-* file. * libcore * external/bouncycastle * external/conscrypt * external/icu * external/okhttp * external/libphonenumber - still has a couple of entries in config/hiddenapi-light-greylist.txt due to limitations in UnsupportedAppUsage/class2greylist. Tested by attempting to upload the file with entries for libcore projects and without those entries and checking that the behavior is expected. Test: see above Bug: 117818301 Change-Id: I67a30b307e12e842b28cfb2160fab0029868fa06
2018-11-28 12:22:14 +00:00
hidden_api_txt_checksorted_hook = ${REPO_ROOT}/frameworks/base/tools/hiddenapi/checksorted_sha.sh ${PREUPLOAD_COMMIT} ${REPO_ROOT}
hidden_api_txt_exclude_hook = ${REPO_ROOT}/frameworks/base/tools/hiddenapi/exclude.sh ${PREUPLOAD_COMMIT} ${REPO_ROOT}
Upload hook that guides people towards AOSP. The canonical location of certain parts of the source tree live in AOSP, and should not be changed internally to avoid merge conflicts. This initially starts with "OWNERS" files, but the hook can easily be repeated to match any files based on file path regexes. Bug: 113136846 Test: manual Change-Id: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38 Merged-In: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
2018-08-23 22:01:53 -06:00
Add ktlint to preupload hooks The kotlin linter is particularly useful for tests written in Kotlin in frameworks/base. This is already merged in internal master. Test: Tried uploading change with/without kotlin style problems. Merged-In: Ie8659765b674ac7b2d82ed3d343f387195c07d83 Change-Id: I420366c49d071e022b8988c3d6293dbc8e9a283a
2019-07-24 15:48:44 +09:00
ktlint_hook = ${REPO_ROOT}/prebuilts/ktlint/ktlint.py -f ${PREUPLOAD_FILES}
Upload hook that guides people towards AOSP. The canonical location of certain parts of the source tree live in AOSP, and should not be changed internally to avoid merge conflicts. This initially starts with "OWNERS" files, but the hook can easily be repeated to match any files based on file path regexes. Bug: 113136846 Test: manual Change-Id: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38 Merged-In: I113e63b6133f20389d84ec0d6d8b81cdbdf35d38
2018-08-23 22:01:53 -06:00
owners_hook = ${REPO_ROOT}/frameworks/base/tools/aosp/aosp_sha.sh ${PREUPLOAD_COMMIT} "OWNERS$"
Added OWNERS to Shell and hook to make sure it's developed on AOSP. Bug: none Test: none Change-Id: I1f6f554cf98c78d1ab8a1e820d485a37238230f5
2018-09-26 11:07:30 -07:00
shell_hook = ${REPO_ROOT}/frameworks/base/tools/aosp/aosp_sha.sh ${PREUPLOAD_COMMIT} "^packages/Shell/"
Reference in New Issue Copy Permalink