drgreen/android_device_google_gs-common
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[BugFix]: Remove the android property used by GXP debug dump [RESTRICT AUTOMERGE]

Browse Source 
"dump_gxp" needs access to gxp android properties earlier.
Granting access causes compatibility issues between P23 & P22 devices,
thus removing this property is the easiest option.

Bug: 287898138
Change-Id: I9ebebbc4f7c47cfbc8efd1d5dede080d79011736
Signed-off-by: Dinesh Yadav <dkyadav@google.com>
This commit is contained in:
Dinesh Yadav 2023-06-20 07:48:07 +00:00
parent 05961615f6
commit 3f904fffac
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
gxp/dump_gxp.cpp
View File

@ -21,17 +21,17 @@
int main() {
/* TODO(b/277094681): Set default value to false around device beta milestone. */
if(::android::base::GetBoolProperty("vendor.gxp.attach_to_bugreport", true)) {
std::string outputDir = concatenatePath(BUGREPORT_PACKING_DIR, "gxp_ssrdump");
printf("Creating %s", outputDir.c_str());
if (mkdir(outputDir.c_str(), 0777) == -1) {
printf("Unable to create folder: %s\n", outputDir.c_str());
return 0;
}
dumpLogs("/data/vendor/ssrdump/coredump", outputDir.c_str(), maxGxpDebugDumps, "coredump_gxp_");
dumpLogs("/data/vendor/ssrdump", outputDir.c_str(), maxGxpDebugDumps, "crashinfo_gxp_");
/* TODO(b/288368306): Create an android property for enabling/disabling
* bugreport collection for gxp */
std::string outputDir = concatenatePath(BUGREPORT_PACKING_DIR, "gxp_ssrdump");
printf("Creating %s", outputDir.c_str());
if (mkdir(outputDir.c_str(), 0777) == -1) {
printf("Unable to create folder: %s\n", outputDir.c_str());
return 0;
}
dumpLogs("/data/vendor/ssrdump/coredump", outputDir.c_str(), maxGxpDebugDumps, "coredump_gxp_");
dumpLogs("/data/vendor/ssrdump", outputDir.c_str(), maxGxpDebugDumps, "crashinfo_gxp_");
return 0;
}